141: Bug 453708 - Support for site/repository-reference/@location in eclipse-repository #145
Conversation
eclipse-repository Task-Url: eclipse-tycho#141 Signed-off-by: Lorenzo Bettini <lorenzo.bettini@gmail.com>
|
@mickaelistria I was also planning to add a more involved IT verifying that a feature with a dependency (taken from a referred repository, e.g., JUnit from Orbit) can be effectively installed (using tycho-eclipserun and the p2 director application, something that I usually do on my projects), what do you think? Should I add this into another PR in case this is going to be merged? |
|
The build failed, but it's not my fault: it timed out due to recent JIRO problems. Could anyone restart it please? |
|
@LorenzoBettini the build is back to normal, if you could add an IT it would be great. |
|
IMO, it's good enough to merge. Some more tests would be welcome, but I don't think we should delay delivery of this feature in snapshots just for that. They can come in further commits. |
|
@mickaelistria thanks for merging! I think this feature is really crucial :) @laeubi the IT was already there and I updated. I was suggesting a more involved IT (maybe an end-to-end test). I'll propose something in another PR along the line I was suggesting |
LorenzoBettini
deleted the
task_141-Bug_453708_Support_for_repository_reference
branch
|
Please also add a note about it to https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md |
here it is #147 |
Closes #141
See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=453708#c19
This PR also adds the type 1 (artifact) reference to the final content.xml (z and jar).
I've also tested locally that with this patch I can finally install features from a p2 repository relying on dependencies stored in referred p2 repositories
Task-Url: #141
Signed-off-by: Lorenzo Bettini lorenzo.bettini@gmail.com