Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dataplaneId null for older TransferProcesses #1534

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Fix: dataplaneId null for older TransferProcesses #1534

merged 5 commits into from
Sep 11, 2024

Conversation

bmg13
Copy link

@bmg13 bmg13 commented Sep 5, 2024 •
edited
Loading

WHAT

Add a fix related with the null dataplaneId value in a TransferProcess.

WHY

To avoid terminated null dp_id's errors. Similar to eclipse-edc/Connector#4420

FURTHER NOTES

Please check eclipse-edc/Connector#4418 for more context

Closes #1535

@bmg13 bmg13 marked this pull request as ready for review September 5, 2024 13:38
@bmg13 bmg13 mentioned this pull request Sep 9, 2024
Closed
@paullatzelsperger paullatzelsperger linked an issue Sep 9, 2024 that may be closed by this pull request
Backport DataPlaneId null as non existing DataFlow in TransferProcess logic to version 0.7.5 #1535
Closed
@bmg13
Copy link
Author

bmg13 commented Sep 9, 2024

@paullatzelsperger @wolf4ood can you please review? 🙇

wolf4ood
wolf4ood requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The porting looks good, but i think the DataPlaneSignalingFlowControllerTest is missing

@paullatzelsperger paullatzelsperger removed their request for review September 10, 2024 04:51
@paullatzelsperger
Copy link
Contributor

@wolf4ood reviewed, so I'm taking my own review off

@bmg13
Copy link
Author

bmg13 commented Sep 10, 2024

The porting looks good, but i think the DataPlaneSignalingFlowControllerTest is missing

you're, right, thank you, added in c86698a

@bmg13 bmg13 requested a review from wolf4ood September 10, 2024 08:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wolf4ood
Copy link
Contributor

wolf4ood commented Sep 10, 2024 •
edited
Loading

@bmg13 i think we also have to port the test when the data plane is null when terminating/suspending

https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R314

https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R262

@bmg13
Copy link
Author

bmg13 commented Sep 10, 2024

@bmg13 i think we also have to port the test when the data plane is null when terminating/suspending

https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R314

https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R262

The termination one was added in a later commit: 60ebfe1
the suspend I did not add since these changes added were only to termination and not to suspension

@wolf4ood wolf4ood merged commit 7a0c2a9 into eclipse-tractusx:bugfix/0.7.5 Sep 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport DataPlaneId null as non existing DataFlow in TransferProcess logic to version 0.7.5
3 participants
@bmg13 @paullatzelsperger @wolf4ood