feat: remove project root from the docker image

[ndr-brt]

WHAT

Avoid to put the whole content of the project into the docker image, aligning the actions image build process with the dockerize task.

WHY

optimization

FURTHER NOTES

further cleanups:

• removed not-needed do_push parameter from the publish-docker-image action
• cleaned up the downloadOtel task using a more "gradle-y" approach
• add opentelemetry version on the version catalog, so it will be kept updated by dependabot
• removed not necessary exclusion from the shadowJar config

Closes #1436

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[paullatzelsperger]

to be honest, I don't quite get the issue. The Dockerfile only copies the runtime JAR, the opentelemetry JAR and the additional files, i.e. legal docs?

[ndr-brt]

to be honest, I don't quite get the issue. The Dockerfile only copies the runtime JAR, the opentelemetry JAR and the additional files, i.e. legal docs?

the root of the problem is that, if you don't specify the ADDITIONAL_FILES build-arg, it will copy everything in the context folder. So, only specifying that build-arg would fix the issue, the rest is cleanup to remove duplication and make everything more understandable.

you can try but checking the difference of the filesystem of the images built by these two commands:

# this will contain everything
docker build . -f edc-controlplane/edc-controlplane-postgresql-azure-vault/build/resources/docker/Dockerfile

# this will contain only what's needed
docker build edc-controlplane/edc-controlplane-postgresql-azure-vault -f edc-controlplane/edc-controlplane-postgresql-azure-vault/build/resources/docker/Dockerfile --build-arg "ADDITIONAL_FILES=build/legal/*"

[paullatzelsperger]

the root of the problem is that, if you don't specify the ADDITIONAL_FILES build-arg, it will copy everything in the context folder.

yep, that is a problem indeed, but we should never have a docker build without ADDITIONAL_FILES, as the legal docs are mandated by EF? Wouldn't this make the problem theoretical in nature?

[ndr-brt]

the root of the problem is that, if you don't specify the ADDITIONAL_FILES build-arg, it will copy everything in the context folder.

yep, that is a problem indeed, but we should never have a docker build without ADDITIONAL_FILES, as the legal docs are mandated by EF? Wouldn't this make the problem theoretical in nature?

if you look at the changelog, in the publish-docker-image it wasn't, so that line I added in the build-push-action job fixed the issue, then I did some refactor to make the dockerize task and the build-push-action call more similar to each other.