Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Decision-Record about removing SFTP extensions #1208

Merged
merged 2 commits into from
Apr 15, 2024
Merged

docs: add Decision-Record about removing SFTP extensions #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8781f11
docs: add Decision-Record about removing SFTP
paullatzelsperger Apr 10, 2024
88512d2
refresh deps temporarily
paullatzelsperger Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,14 @@ jobs:

- name: Run E2E tests (${{ matrix.variant.dir }})
run: |
./gradlew compileJava compileTestJava
./gradlew -p ${{ matrix.variant.dir }} test -DincludeTags="EndToEndTest"
./gradlew compileJava compileTestJava --refresh-dependencies
./gradlew -p ${{ matrix.variant.dir }} test -DincludeTags="EndToEndTest"
postgres-tests:
runs-on: ubuntu-latest
services:
postgres:
image: postgres:14.2
image: postgres:16.1
ports:
- 5432:5432
env:
Expand All @@ -143,7 +143,7 @@ jobs:
- uses: ./.github/actions/setup-java

- name: Run Postgresql E2E tests
run: ./gradlew test -DincludeTags="PostgresqlIntegrationTest"
run: ./gradlew test -DincludeTags="PostgresqlIntegrationTest" --refresh-dependencies

dataplane-tests:
runs-on: ubuntu-latest
Expand Down
14 changes: 14 additions & 0 deletions docs/development/decision-records/2024-04-11_remove_sftp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Remove SFTP modules

## Decision

Starting with the next release of Tractus-X EDC, the SFTP modules will be removed from the code base. Specifically `transferprocess-sftp-client`, `transferprocess-sftp-common` and `transferprocess-sftp-provisioner`.

## Rationale

These modules don't implement any official Catena-X Standard, and as such, have not been part of any official Tractus-X EDC distribution for a significant period of time.
Further, those modules are not up to the coding standards established by Tractus-X EDC, and would have to be refactored significantly. Even then, having dead code in a repository is bad hygiene, as it generates maintenance churn. Tractus-X EDC is not responsible for maintaining niche extensions, that are not officially sanctioned.

## Approach

Starting with version `0.8.x` of Tractus-X EDC, these modules will be deleted from the code base. At that time, stakeholders interested in continuing to maintain them are welcome to adopt them into their own repositories.
Loading