fix: add expiry check to DataPlaneTokenRefreshServiceImpl #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/add_expiry_check
branch
from
e2d2831
to
364037f
Compare
paullatzelsperger
force-pushed
the
feat/add_expiry_check
branch
from
364037f
to
455947a
Compare
|
8 tasks
paullatzelsperger
changed the title
wolf4ood
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR adds a check for token expiry to the
DataPlaneTokenRefreshServiceto reject resolving expired access tokens.WHY
the
resolve()method is called during authorization of a HTTP pull request against the dataplane, so in Tractus-X EDC it needs to reject expired access tokens.FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists