Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Langium and apply new langium-sprotty features #104

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Update Langium and apply new langium-sprotty features #104

merged 2 commits into from
Jun 4, 2024

Conversation

spoenemann
Copy link
Contributor

@spoenemann spoenemann commented May 14, 2024 •
edited
Loading

This updates Langium to v3.0.0 so we can use the new features introduced in eclipse-langium/langium#1312.

Additional changes:

  • Fixed paths in launch.json
  • Migrated from Webpack to Esbuild
  • Update sprotty-server to 1.1.1 (in the Xtext language server)
  • A few more improvements along the way

@cdietrich
Copy link
Contributor

@spoenemann will this also allow to be used with newer sprotty? see

sprotty-vscode/packages/sprotty-vscode-webview/package.json

Line 31 in 24a1a1c

"sprotty": "^1.0.0",

@cdietrich
Copy link
Contributor

i propose to use something newer in ext.xtextVersion = '2.26.0'
to avoid gradle resolver going amok

@cdietrich
Copy link
Contributor

#105

gfontorbe
gfontorbe approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoenemann spoenemann merged commit 918b000 into master Jun 4, 2024
2 checks passed
@spoenemann spoenemann deleted the langium-edit branch June 4, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfontorbe gfontorbe gfontorbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spoenemann @cdietrich @gfontorbe