Map all to a subset of platforms for PR builds #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adam compile all jdk11 |
AdamBrousseau
changed the title
AdamBrousseau
force-pushed
the
support_all_prs
branch
from
52df301
to
d896db6
Compare
|
adam compile all jdk11 |
AdamBrousseau
force-pushed
the
support_all_prs
branch
from
d896db6
to
44f5580
Compare
|
adam compile all,osxxl jdk11 |
|
https://ci.eclipse.org/openj9/view/Pull%20Requests/job/Adam-PullRequest-OpenJ9/21/console |
|
adam compile osxxl jdk11 |
|
https://ci.eclipse.org/openj9/view/Pull%20Requests/job/Adam-PullRequest-OpenJ9/22/console |
|
@vsebe for review |
AdamBrousseau
changed the title
vsebe
suggested changes
May 15, 2019
| @@ -673,7 +673,9 @@ def setup_pull_request() { | |||
| PARSED_PLATFORMS.each { SHORT -> | |||
| LONG_PLATFORM = SHORT_NAMES["${SHORT}"] | |||
| if (LONG_PLATFORM) { | |||
| PLATFORMS.add(LONG_PLATFORM) | |||
| LONG_PLATFORM.tokenize(',').each { | |||
There was a problem hiding this comment.
Use List.addAll(): PLATFORMS.addAll(LONG_PLATFORM.tokenize(','))
There was a problem hiding this comment.
Don't think we need the tokenize with the addAll
00:00:56.736 PLATFORMS:'[ppc64le_linux, s390x_linux, x86-64_linux, x86-64_linux_xl, ppc64_aix, x86-64_windows, x86-32_windows, x86-64_mac, x86-64_mac_xl]'
| @@ -91,7 +91,7 @@ SPECS = ['ppc64_aix' : CURRENT_RELEASES, | |||
|
|
|||
| // SHORT_NAMES is used for PullRequest triggers | |||
| // TODO Combine SHORT_NAMES and SPECS | |||
| SHORT_NAMES = ['all' : 'all', | |||
| SHORT_NAMES = ['all' : 'ppc64le_linux,s390x_linux,x86-64_linux,x86-64_linux_xl,ppc64_aix,x86-64_windows,x86-32_windows,x86-64_mac', | |||
There was a problem hiding this comment.
Could this be a List instead of a comma separated strings (thus remove LONG_PLATFORM.tokenize(',') in pipeline-functions)?
|
adam compile all,osxxl jdk11 |
|
adam compile osxxl jdk11 |
|
adam compile all jdk11 |
|
Looks good. Please review |
- xlinux - xlinuxXL - osx - win - win32 - aix - plinux - zlinux - Also change the values to be lists in order to support multiple values [skip ci] Related eclipse-openj9#2836 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
support_all_prs
branch
from
62fd743
to
51b5dc9
Compare
vsebe
approved these changes
May 15, 2019
pshipton
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support multiple values
[skip ci]
Related #2836
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com