Handle errors deleting attach API files #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this change be un-excluding test_startupShutdownRobustness if the issues are resolved? |
Add null checks where necessary. Suppress exceptions in deleteRecursive() if errors are possible and acceptable. Re-enable affected tests. [skip ci] Fixes issue eclipse-openj9#2047 and issue eclipse-openj9#2141 Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
Tests re-enabled. |
|
jenkins test extended aix jdk10 |
|
jenkins test extended plinux jdk8 |
|
All tests passed. |
llxia
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null checks where necessary. Suppress exceptions in deleteRecursive() if
errors are possible and acceptable.
Fixes issue #2047 and issue #2141
Tested in a manual build.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com