Fix "storing the address of local variable" in trcmain.c #20172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stops storing the address of a local variable, to fix a build error with runtime/rastrace/trcmain.c. Fixes: eclipse-openj9#20171 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
Jenkins test sanity amac jdk11 |
knn-k
commented
Sep 17, 2024
keithc-ca
requested changes
Sep 18, 2024
Comment on lines
+1041
to
+1042
| memset(tempThr, 0, sizeof(UtThreadData)); | ||
| initHeader(&(tempThr->header), UT_THREAD_DATA_NAME, sizeof(UtThreadData)); |
There was a problem hiding this comment.
Please update the documentation in rastrace_external.h. It currently says
* @param[out] thr A UtThreadData pointer. *thr can point to NULL, initialize trace will initialize it.
That is not true: if NULL == *thr, this will fail.
| @@ -333,6 +334,7 @@ J9VMDllMain(J9JavaVM *vm, IDATA stage, void *reserved) | |||
| * Find UTE thread slot inside VM thread structure | |||
| */ | |||
| tempThr = UT_THREAD_FROM_VM_THREAD(vm->mainThread); | |||
| *tempThr = &thrData; | |||
There was a problem hiding this comment.
I think some comments (or assertions) would be helpful:
- before line 337
*tempThris expected to beNULL - after the call to
initializeTrace()*tempThris again expected to beNULL(eliminating the reference tothrData) - the call to
threadStart()should allocate storage to which*tempThrwill then point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stops storing the address of a local variable, to fix a build error with runtime/rastrace/trcmain.c.
Fixes: #20171