Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile AST node to provide accurate type definition snippets #2912

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Reconcile AST node to provide accurate type definition snippets #2912

merged 1 commit into from
Oct 20, 2023

Conversation

hopehadfield
Copy link
Contributor

@hopehadfield hopehadfield commented Oct 18, 2023 •
edited by rgrunber
Loading

rgrunber
rgrunber reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind accepting this in its current state. However, if we run into any performance issues down the road, we might consider moving the makeConsistent into completionItem/resolve and maybe do more of the snippet construction in the resolve phase.

...dt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/SnippetCompletionProposal.java Outdated Show resolved Hide resolved
@rgrunber
Copy link
Contributor

@snjeza , can you confirm that such usage is safe from a performance aspect ? This seems to ensure the state of the model accurately reflects the file content.

@hopehadfield
Reconcile AST node to provide accurate type definition snippets
6818b99 
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@rgrunber rgrunber merged commit ff00f43 into eclipse-jdtls:master Oct 20, 2023
6 checks passed
@rgrunber rgrunber added this to the End October 2023 milestone Oct 20, 2023
@hopehadfield hopehadfield deleted the 2250-replace branch October 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End October 2023
Development

Successfully merging this pull request may close these issues.

Get a different snippet code if just replace not delete the previous one
2 participants
@hopehadfield @rgrunber