Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check additionalTextEdits & documentation resolve support via standard LSP #2598

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Check additionalTextEdits & documentation resolve support via standard LSP #2598

merged 1 commit into from
Apr 17, 2023

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Apr 17, 2023 •
edited
Loading

Related with the issue: #2584

Client side PR: redhat-developer/vscode-java#3070

This PR first check the resolve support for additionalTextEdits & documentation

Check for testEdit will come next.

@jdneo jdneo mentioned this pull request Apr 17, 2023
Merged
@jdneo
Check additionalTextEdits & documentation resolve support via standar…
7708b27 
…d LSP

Signed-off-by: Sheng Chen <sheche@microsoft.com>
testforstephen
testforstephen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It makes sense to check the standard LSP client capabilities for the supported lazy resolve properties.

@testforstephen testforstephen added this to the End April 2023 milestone Apr 17, 2023
@fbricon fbricon merged commit 23a3242 into eclipse-jdtls:master Apr 17, 2023
@fbricon
Copy link
Contributor

fbricon commented Apr 17, 2023

Thanks @jdneo

@mfussenegger mfussenegger mentioned this pull request Apr 17, 2023
Closed
@jdneo jdneo deleted the cs/completionResolveCap branch April 18, 2023 01:46
This was referenced Apr 18, 2023
Open
Closed
@jdneo
Copy link
Contributor Author

jdneo commented Apr 18, 2023

@mfussenegger @akurtakov @mickaelistria @puremourning for awareness.

If you set additionalTextEdits in resolveSupport during initialization, then there is no need to set resolveAdditionalTextEditsSupport in the extendedClientCapabilities

mfussenegger added a commit to mfussenegger/dotfiles that referenced this pull request Apr 20, 2023
@mfussenegger
vim/java: Remove custom resolveAdditionalTextEditsSupport
84829b9 
No longer needed: eclipse-jdtls/eclipse.jdt.ls#2598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

@fbricon fbricon Awaiting requested review from fbricon

@snjeza snjeza Awaiting requested review from snjeza

@rgrunber rgrunber Awaiting requested review from rgrunber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End April 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@jdneo @fbricon @testforstephen