Display debug port

[pzygielo]

Test:

1. get https://ci.eclipse.org/glassfish/job/glassfish_build-and-test-using-jenkinsfile/job/PR-24955/1/artifact/bundles/glassfish.zip and unpack
2. execute and inspect output:

$ ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start ...........
Waiting finished after 10,150 ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: 4,848
Debugging is enabled.  The debugging port is: 9,009
Command start-domain executed successfully.

[arjantijms]

Looks good. Tiny comment, but it's already in the other values too; "9,009" vs "9009"

[pzygielo]

Tiny comment, but it's already in the other values too; "9,009" vs "9009"

I don't understand that comment.

Logged message formatting step is locale-dependent, and one can get dot instead of comma as grouping character easily (observe for Waiting finished or Admin port as well):

$ LC_ALL=nl_NL.utf8 ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .......
Waiting finished after 6.666 ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: 4.848
Debugging is enabled.  The debugging port is: 9.009
Command start-domain executed successfully.

or

$ LC_ALL=lv_LV.utf8 ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start ......
Waiting finished after 5 974 ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: 4 848
Debugging is enabled.  The debugging port is: 9 009
Command start-domain executed successfully.

or

$ LC_ALL=sd_IN ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .......
Waiting finished after ٦٬٥٤٦ ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: ٤٬٨٤٨
Debugging is enabled.  The debugging port is: ٩٬٠٠٩
Command start-domain executed successfully.

[dmatej]

Wow, good catch, however we should make it yet more robust (address is not just a port) ... on the other hand I don't expect anyone would debug on production, so it is ok.

[arjantijms]

Tiny comment, but it's already in the other values too; "9,009" vs "9009"

I don't understand that comment.

Logged message formatting step is locale-dependent, and one can get dot instead of comma as grouping character easily (observe for Waiting finished or Admin port as well):

$ LC_ALL=nl_NL.utf8 ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .......
Waiting finished after 6.666 ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: 4.848
Debugging is enabled.  The debugging port is: 9.009
Command start-domain executed successfully.

or

$ LC_ALL=lv_LV.utf8 ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start ......
Waiting finished after 5 974 ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: 4 848
Debugging is enabled.  The debugging port is: 9 009
Command start-domain executed successfully.

or

$ LC_ALL=sd_IN ./glassfish7/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .......
Waiting finished after ٦٬٥٤٦ ms.
Successfully started the domain : domain1
domain  Location: .../glassfish7/glassfish/domains/domain1
Log File: .../glassfish7/glassfish/domains/domain1/logs/server.log
Admin Port: ٤٬٨٤٨
Debugging is enabled.  The debugging port is: ٩٬٠٠٩
Command start-domain executed successfully.

I think it should perhaps not be formatted as a number at all, just as a string. So it should be just "9009", imho. Of course it doesn't matter too much.

[pzygielo]

I think it should perhaps not be formatted as a number at all, just as a string. So it should be just "9009", imho.

• Going from (unformatted) String to int (to be handled by Formatter): Revisited stop/start of GlassFish servers #24200.

[pzygielo]

we should make it yet more robust (address is not just a port)

Can you elaborate? The term address is only used as agent's parameter (not under GF control), the help page is only about port and the message is only about port. Not clear what change you'd like to see.

[dmatej]

we should make it yet more robust (address is not just a port)

Can you elaborate? The term address is only used as agent's parameter (not under GF control), the help page is only about port and the message is only about port. Not clear what change you'd like to see.

Just forget it, it was just a short idea related to the address - user can enable the debug port just on specific IP, generally, but we don't need it and it would make user's life harder than just using the --debug parameter.

[pzygielo]

user can enable the debug port just on specific IP

True. I only considered the case (*:) present in template domain.xml, indeed.
This however, fortunately, does not block the debug itself. It is just that message is not displayed then (for the NFEx).