feat: base64-url encoded participantId in API controllers
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
added
enhancement
...i/src/main/java/org/eclipse/edc/identityhub/api/keypair/v1/KeyPairResourceApiController.java
Outdated
Show resolved
Hide resolved
e2e-tests/api-tests/build.gradle.kts
Outdated
| @@ -16,6 +16,8 @@ dependencies { | |||
| testImplementation(testFixtures(project(":spi:identity-hub-spi"))) | |||
| testImplementation(libs.nimbus.jwt) | |||
| testImplementation(libs.jakarta.rsApi) | |||
|
|
|||
| testRuntimeOnly(project(":launcher")) | |||
There was a problem hiding this comment.
is this on purpose? and if so, am I correct in assuming that this is to add a task dependency from :e2e-tests:api-tests -> :launcher, causing the latter to be compiled with the earlier?
There was a problem hiding this comment.
On my windows laptop, it does not work without that addition.
There was a problem hiding this comment.
have you tried executing compileJava and compileTestJava first? We really shouldn't have dependencies onto launcher modules....
bscholtes1A
force-pushed
the
feat/participant_id_path_segment_base64url
branch
from
112cba2
to
9dd8602
Compare
paullatzelsperger
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR changes behavior of the controllers to that the
participantIdpassed in the request path segment is now assumed to be base64-url encoded.Why it does that
Avoid collision when the actual
participantIdcontains characters that should not be encoded when calling the APIs.Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.