Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget is disposed error during shutdown #48

Conversation

Torbjorn-Svensson
Copy link
Member

After building a project and shuting down eclipse, the build console
will have a propertyChange event fired that will attempt to modify the
stream and background color that will trigger a use-after-dispose error
from SWT. This changeset ensures that the action is only taken on
non-disposed widgets.

Contributed by STMicroelectronics

Change-Id: I872c28da1b2fca7ec39f5b12d9d1ec398e559814
Signed-off-by: Torbjörn Svensson torbjorn.svensson@st.com

After building a project and shuting down eclipse, the build console
will have a propertyChange event fired that will attempt to modify the
stream and background color that will trigger a use-after-dispose error
from SWT. This changeset ensures that the action is only taken on
non-disposed widgets.

Contributed by STMicroelectronics

Change-Id: I872c28da1b2fca7ec39f5b12d9d1ec398e559814
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
@Torbjorn-Svensson
Copy link
Member Author

@jonahgraham: I think this changeset is a candidate for 10.7.x

@Torbjorn-Svensson
Copy link
Member Author

@Torbjorn-Svensson Torbjorn-Svensson added this to the 11.0.0 milestone Aug 16, 2022
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good for 10.7.1 too.

@Torbjorn-Svensson Torbjorn-Svensson merged commit 5aee96d into eclipse-cdt:main Aug 16, 2022
@Torbjorn-Svensson Torbjorn-Svensson deleted the pr/widget-is-disposed-error-during-shutdown branch August 16, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants