Use fflate to decompress package list chunks #1456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While r2modman used Node's zlib as intended, TSMM used a library that happened to be present as a 2nd degree dependency. While it worked, the library had poor performance, taking ~3s to decompress each chunk, while zlib and fflate takes next to no time at all. Using DecompressionStream instead was considered, but based on a single google result it seems that would require updating the TypeScript version, which is a side quest for another time. It was also considered sniffing the app version and using fflate only on TSMM, so it wouldn't need to be added as a dependency on r2modman. In the end gut feeling decided that would be unnecessarily complex and prone to break due to future changes.
VilppeRiskidev
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While r2modman used Node's zlib as intended, TSMM used a library that happened to be present as a 2nd degree dependency. While it worked, the library had poor performance, taking ~3s to decompress each chunk, while zlib and fflate takes next to no time at all.
Using DecompressionStream instead was considered, but based on a single google result it seems that would require updating the TypeScript version, which is a side quest for another time.
It was also considered sniffing the app version and using fflate only on TSMM, so it wouldn't need to be added as a dependency on r2modman. In the end gut feeling decided that would be unnecessarily complex and prone to break due to future changes.