-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile import summary #1430
Profile import summary #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code changes look fine. Couple of possible issues:
- Any local mods in the imported profile are not shown on the preview
- https://github.com/ebkr/r2modmanPlus/blob/develop/src/r2mm/downloading/BetterThunderstoreDownloader.ts#L209 has this checkup for importing profiles that contains no mods found in Thunderstore's API. Usually this is due to importing the profile to a wrong game, but could be due to mod takedowns as well. Currently the preview is empty and if user proceeds the error is shown as before. It would be better UX to handle the "empty profile" case already on the preview phase and not let the user proceed.
I think these are somewhat niche cases so IDK if they should be considered blockers. The feature itself is probably valuable for most of the users as it is now.
Locally imported mods aren't included anyway. We could potentially indicate which ones but I don't think it's a concern and is honestly probably better to inform the original exporter rather than the person importing the profile.
That's a good spot that I didn't consider - I'll add a new path to say that there are no resolvable mods to import for that code. |
Okay so what tripped me up on this is that the locally imported mods are included in the
Yeah, this is now a lot nicer experience for the user 👍 |
Hope I'm not jumping the gun when I merge this to get the changes to TSMM release. |
This PR aims to allow users to see which mods are going to be installed when importing a profile