Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button to copy launch arguments easier #1339

Merged
merged 3 commits into from
May 31, 2024

Conversation

ebkr
Copy link
Owner

@ebkr ebkr commented May 27, 2024

Resolves #1158

Screenshots

image

image

@ebkr ebkr requested a review from anttimaki May 27, 2024 09:05
@ebkr ebkr self-assigned this May 27, 2024
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I don't consider it a major issue, but the tooltip doesn't seem to work. Anyway I'd argue that tooltip that says the same as the button itself provides no value so it should be removed altogether.

<template v-if="doorstopTarget.length > 0">
<p>
<button class="button" @click="copyDoorstopTargetToClipboard" v-if="!copyingDoorstopText">
<i class="fas fa-clipboard" v-tooltip.left="'Drag to reorder'"></i>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Says "Drag to reorder". Anyway, I don't see this or the "Copy launch arguments" tooltip at all?

@ebkr
Copy link
Owner Author

ebkr commented May 29, 2024

The tooltip was likely just from a bad copy/paste job on another item that had a tooltip. Will remove.

Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebkr ebkr merged commit 53e2a90 into develop May 31, 2024
7 checks passed
@ebkr ebkr deleted the copy-launch-parameters-button branch May 31, 2024 21:52
@Guessed8822
Copy link

@ebkr thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] - Enable right-click or add a "Copy" button for launch parameters.
3 participants