Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple simultaneous package list updates #1311

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Prevent multiple simultaneous package list updates #1311

merged 3 commits into from
Apr 29, 2024

Commits on Apr 26, 2024

  1. UtilityMixin: do route-based mod list update blocking earlier 

    There seems to be no point in waiting to do this check, so do it as
early as possible. This also makes the first function to only do the
update and consolidates all the auxiliary stuff into the second
function.
    @anttimaki
    anttimaki committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e126952 View commit details
    Browse the repository at this point in the history

  2. Prevent running multiple mod list background updates simultaneously 

    Online mod list is currently updated on the background every 5 minutes.
Ideally downloading and processing the mod list wouldn't take that long
that the interval would fire before an earlier round has finished, but
the most popular games have so many mods that on people with slower
connections this seems to happen. Multiple connections then compete for
the same download bandwidth, making the process even slower.
    @anttimaki
    anttimaki committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    75a5bbc View commit details
    Browse the repository at this point in the history

  3. Prevent manual and automatic mod list updates running simultaneously 

    Users can trigger updating the online mod list from the settings view.
Use the status text to show if an update is already in progress and
prevent user actions from triggering another one, since they would just
compete for the same bandwidth and slow down the manager.
    @anttimaki
    anttimaki committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    13a9873 View commit details
    Browse the repository at this point in the history