DownloadModModal refactoring #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact same method couldn't be for .downloadSpecific() since it has a bit different functionality and passing a specific Profile would require changes to DownloadProvider interfaces.
None of the methods in DownloadProviders expect completedCallback argument to return an error, or any value for that matter. .downloadSpecific() which returns a promise should reject the error so the caller in Manager.vue can handle it with promise's catch. The methods called by UI components in DownloadModModule that use the .downloadCompletedCallback() helper should open the error modal themselves.
Changing from any type to a proper type reveals that the object can be null in couple of places - non-null assertions are used for these to avoid having to deal with these right now.
anttimaki
force-pushed
the
downloadmodmodal-refactoring
branch
from
8c01d57
to
52ed2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did the changes as preparation for showing installation progress along the download progress. That turned to be a more complex issue than I first thought, so it's on a backburner for now. But I think the changes here can be merged anyways.