Mount dependency string modal only when it's opened #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal rerenders when ever the local mod list updates. This is unnecessary since the list can be changed from e.g. LocalModList, while the modal can be opened only from the settings view. Normally this wouldn't be much of a problem, but currently the method that's used to get the list of local mods does some extra stuff and is slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal rerenders when ever the local mod list updates. This is unnecessary since the list can be changed from e.g. LocalModList, while the modal can be opened only from the settings view.
Normally this wouldn't be much of a problem, but currently the method that's used to get the list of local mods does some extra stuff and is slow.