Store list of local mods with updates on VueX #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a profile with 109 mods and 40 updateable mods, calling DownloadProvider's getLatestOfAllToUpdate takes a second or two. - When entering local mod list, it gets called twice: once to show the banner about available updates, and once by DownloadModModal - While in settings view once per second due to setInterval in SettingsItem (that might also be something to look into) - Ridiculous number of times when the mods were updated via DownloadModModal. The update time for the example profile went from 315 seconds to 65 seconds (all downloads were cached both times) Calling the method in VueX getter caches the value for subsequent calls, reducing the duration to milliseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a profile with 109 mods and 40 updateable mods, calling DownloadProvider's getLatestOfAllToUpdate takes a second or two.
Calling the method in VueX getter caches the value for subsequent calls, reducing the duration to milliseconds.