Improve Splash screen download indicators #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anttimaki
commented
Jan 22, 2024
anttimaki
commented
- Calculate package list download progress percentage if possible. This requires that the response headers contain the total length of the content, which is not guaranteed.
- Set exclusion list download progress to 100 when done. Previously this would be left to 0 if the response headers didn't contain the content length.
- Set package list download progress to 100 when done, even if the download fails. Strictly speaking this wouldn't be necessary since the progress bar is hidden after this step, but it might prevent issues in the future if the UI is changed.
- Reset all progress to 0 if user attempts to reconnect after some part of the process has failed.
- Calculate package list download progress percentage if possible. This requires that the response headers contain the total length of the content, which is not guaranteed. - Set exclusion list download progress to 100 when done. Previously this would be left to 0 if the response headers didn't contain the content length. - Set package list download progress to 100 when done, even if the download fails. Strictly speaking this wouldn't be necessary since the progress bar is hidden after this step, but it might prevent issues in the future if the UI is changed. - Reset all progress to 0 if user attempts to reconnect after some part of the process has failed.
MythicManiac
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.