Request Header Updates (User-Agent, Accept-Language) #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Per https://tools.ietf.org/html/draft-ietf-acme-acme-07#section-6.1 the ACME client should be set by the software * Updated the AcmeProtocol.HTTP_USER_AGENT_FMT per RFC 7231 5.5.3 format
* per https://tools.ietf.org/html/draft-ietf-acme-acme-07#section-6.1 the language header should be set to allow ACME to send localized error messages
Marcus-L
changed the title
|
Added Accept-Language header as well to allow the ACME service to return localized error messages (also per https://tools.ietf.org/html/draft-ietf-acme-acme-07#section-6.1) |
This was referenced Oct 8, 2017
Closed
|
Changes look great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed UserAgent to be set by users of the AcmeClient (per https://tools.ietf.org/html/draft-ietf-acme-acme-07#section-6.1 the ACME client should be set by the software).
Updated the AcmeProtocol.HTTP_USER_AGENT_FMT per RFC 7231 5.5.3 format, to use "/" instead of space and remove the "v".
Best practice would be for the AcmeClient users to simply append (or prepend) their User Agent string to the existing ACMEdotNET one, ex: "Certify/2.0.13 ACMEdotNET/0.9.0.323 (ACME 1.0)"