You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think SequenceNumber.h needs a review. At lines 79 and 87, the compares to pow(2.0,32) will always be false and incrementing beyond 32 bits won't work. At line 100, the LHS of the > will be done with 32 bits (then promoted to double) so that test will always be false. At line 102, 'module' will always be zero (due to integer overflow). I think some of the later operators also suffer similar problems.
I have not seen any of this cause any problems (it would take a while :) ), but just ran across it looking for other issues.
The text was updated successfully, but these errors were encountered:
I think SequenceNumber.h needs a review. At lines 79 and 87, the compares to pow(2.0,32) will always be false and incrementing beyond 32 bits won't work. At line 100, the LHS of the > will be done with 32 bits (then promoted to double) so that test will always be false. At line 102, 'module' will always be zero (due to integer overflow). I think some of the later operators also suffer similar problems.
I have not seen any of this cause any problems (it would take a while :) ), but just ran across it looking for other issues.
The text was updated successfully, but these errors were encountered: