Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceNumber.h #27

Closed
johnfinley opened this issue Mar 8, 2016 · 1 comment
Closed

SequenceNumber.h #27

johnfinley opened this issue Mar 8, 2016 · 1 comment

Comments

@johnfinley
Copy link

I think SequenceNumber.h needs a review. At lines 79 and 87, the compares to pow(2.0,32) will always be false and incrementing beyond 32 bits won't work. At line 100, the LHS of the > will be done with 32 bits (then promoted to double) so that test will always be false. At line 102, 'module' will always be zero (due to integer overflow). I think some of the later operators also suffer similar problems.

I have not seen any of this cause any problems (it would take a while :) ), but just ran across it looking for other issues.

@richiprosima
Copy link
Contributor

SequenceNumber.h was changed and now it doesn't use pow function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants