feat(foreach): ✨ add statement to exit from a foreach loop #841
Conversation
src/lua/zencode_foreach.lua
Outdated
| @@ -64,3 +64,8 @@ Foreach("'' in sequence from '' to '' with step ''", function(name, from_name, t | |||
| end | |||
| end | |||
| end) | |||
|
|
|||
| When("exit from foreach loop", function() | |||
There was a problem hiding this comment.
best use:
exit foreach loop
which will support also exit the
unsure if to use break as a verb, more used in other langs
There was a problem hiding this comment.
I had also the same doubt about using exit or break, maybe break foreach loop can be a better solution, what do you think?
There was a problem hiding this comment.
If we are unsure qe can have them as alias both exit and break
There was a problem hiding this comment.
Yes to aliasing both exit and break.
I checked and the word loop is not mentioned anywhere so:
break foreach
exit foreach
One doubt left since endforeach is used as one word to mark end of branch... I think there will be confusion later on about having the word separated, as well between exit and end.
There was a problem hiding this comment.
The main difference between exit/break foreach and endforeach is that the former is a When statement, i.e.
When I break the foreachWhile the latter is just a keyword to mark the end of the code to be repeated in a foreach loop.
To me this separation make sense
Add also break alias
…aving the shcema in the iterator codec when present
|
I think my doubts can be set aside and as you say it seems coherent to break inside a statement rather than prefix. Merging. Very well done! |
No description provided.