fix: 🐛 improve chain id import in ethereum transaction #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now chain id can also be imported from KEYS or DATA. Chain ID can have encoding 'string' or 'integer'. When the chain id is set, we look at ACK and see if the variable references a value which is loaded. In this case: - if the encoding is 'integer' his numeric value is imported. - if the encoding is 'string' we try to import its numeric value, if it fails we import it as `O.from_string` (backward compatibility) If the name is not loaded from keys or data, we use the value inside the zencode script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now chain id can also be imported from KEYS or DATA.
Chain ID can have encoding 'string' or 'integer'.
When the chain id is set, we look at ACK and see if the
variable references a value which is loaded. In this case:
if it fails we import it as
O.from_string(backward compatibility)If the name is not loaded from keys or data, we use the value inside
the zencode script