This repository has been archived by the owner on May 5, 2022. It is now read-only.
Overwrite limit_clause in TrinoSQLCompiler #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungdm93
suggested changes
Nov 25, 2021
|
@long2ice Thank for your contribution |
|
Done |
dungdm93
reviewed
Nov 26, 2021
| ) | ||
|
|
||
|
|
||
| def test_limit_offset(): |
There was a problem hiding this comment.
2 more test cases:
select(table).limit(10)select(table).offset(3)
|
Done |
dungdm93
reviewed
Nov 26, 2021
sqlalchemy_trino/compiler.py
Outdated
| @@ -80,7 +80,18 @@ | |||
|
|
|||
|
|
|||
| class TrinoSQLCompiler(compiler.SQLCompiler): | |||
| pass | |||
| """ | |||
| Trino support only OFFSET...LIMIT but not LIMIT...OFFSET syntax. | |||
There was a problem hiding this comment.
This should be docstring for method limit_clause, not for class TrinoSQLCompiler
|
@long2ice LGTM, but one small comment on docstring. |
|
That's right |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See trinodb/trino#4335