Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test add optimism airdrop addresses #1516

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

soispoke
Copy link
Contributor

@soispoke soispoke commented Sep 6, 2022

Brief comments on the purpose of your changes:

For Dune Engine V2
I've checked that:
General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if adding a new model, I edited the alter table macro to display new database object (table or view) in UI explorer
  • if adding a new materialized table, I edited the optimize table macro

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@soispoke soispoke requested a review from aalan3 September 6, 2022 13:55
Copy link
Contributor

@aalan3 aalan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise lgtm

dbt_project.yml Outdated
@@ -28,6 +28,12 @@ models:
ens:
+schema: ens
+materialized: view
airdrop:
+schema: airdrop
+materialized: view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and below should be table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalan3 oh right, I just enforced it directly in the model but you're right, it's safer to have it by default here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@soispoke soispoke merged commit 553c8cf into main Sep 6, 2022
@soispoke
Copy link
Contributor Author

soispoke commented Sep 6, 2022

@chuxinh @MSilb7 In this PR, I experimented with the airdrop optimism addresses table to improve submissions of big/static tables into V2. It turns out materializing it as tables and following the format I used here works well. @chuxinh could you use the same format for the other tables you wanted to add here #1509 ? @MSilb7 Can you check and lmk if I can delete the old airdrop table and keep this one instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants