Handle iframe with src="about:blank" #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhyndman
requested review from
Jonathan1600,
hongrich,
kierrrrra and
umairnadeem
hongrich
approved these changes
Apr 2, 2024
| const iframe = document.createElement('iframe'); | ||
| // "src" is technically a required field in HTML iframes. Many libraries work around | ||
| // this by specifying the url "about:blank". we should handle this scenario. | ||
| iframe.src = 'about:blank'; |
There was a problem hiding this comment.
From https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/src
Note that programmatically removing an <iframe>'s src attribute (e.g. via Element.removeAttribute()) causes about:blank to be loaded in the frame.
Do you think it's worth having a test that simulates this (in other words, programmatically remove the src attribute)?
There was a problem hiding this comment.
I did actually try this manually. In all of the browsers I have installed, the contents of the iframe may be about:blank, but the src attribute itself remains empty.
So I think this finding was a bit of a red herring on my part, and our existing code already handles that well. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like some segment of the industry has landed on the use of
src="about:blank"as a backward compatible alternative to generating an iframe with nosrcattribute.https://stackoverflow.com/questions/5946607/is-an-empty-iframe-src-valid
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/src
This change ensures that mounting an
<iframe src="about:blank">will not cause the ResourceIdleObservable class to stall.