Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new badges #46

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Added new badges #46

merged 2 commits into from
Jun 7, 2022

Conversation

Jonathan1600
Copy link
Collaborator

After open sourcing we can finally add some badges, two of them show as pending but I hope they will resolve soon.

README.md Outdated
@@ -5,6 +5,12 @@
<img src="https://img.shields.io/npm/dt/@dropbox/ttvc"/>
<img src="https://img.shields.io/bundlephobia/minzip/@dropbox/ttvc"/>
<img src="https://img.shields.io/bundlephobia/min/@dropbox/ttvc"/>
<img src="https://img.shields.io/github/checks-status/dropbox/ttvc/main"/>
<img src="https://img.shields.io/github/checks-status/dropbox/ttvc/main"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've got this badge listed twice. Were you trying to include something else, or should we just remove one?

README.md Outdated
Comment on lines 10 to 13
<img src="https://img.shields.io/github/issues-raw/dropbox/ttvc"/>
<img src="https://img.shields.io/github/issues-closed-raw/dropbox/ttvc"/>
<img src="https://img.shields.io/github/license/dropbox/ttvc"/>
<img src="https://img.shields.io/github/commit-activity/m/dropbox/ttvc"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is neat that all of these are possible, but I feel some of them might be distracting from the interesting information, haha. 😅

(Also, I'm not sure highlighting the very limited activity we've had so far is super helpful! 😉)

I think I'd rather remove these... for now. Are you okay with that?

README.md Outdated
Comment on lines 10 to 13
<img src="https://img.shields.io/github/issues-raw/dropbox/ttvc"/>
<img src="https://img.shields.io/github/issues-closed-raw/dropbox/ttvc"/>
<img src="https://img.shields.io/github/license/dropbox/ttvc"/>
<img src="https://img.shields.io/github/commit-activity/m/dropbox/ttvc"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is neat that all of these are possible, but I feel some of them might be distracting from the interesting information, haha. 😅

(Also, I'm not sure highlighting the very limited activity we've had so far is super helpful! 😉)

I think I'd rather remove these... for now. Are you okay with that?

@Jonathan1600
Copy link
Collaborator Author

I agree those were just some options since I didn't know what else to include 😅

README.md Outdated
@@ -5,6 +5,12 @@
<img src="https://img.shields.io/npm/dt/@dropbox/ttvc"/>
<img src="https://img.shields.io/bundlephobia/minzip/@dropbox/ttvc"/>
<img src="https://img.shields.io/bundlephobia/min/@dropbox/ttvc"/>
<img src="https://img.shields.io/github/checks-status/dropbox/ttvc/main"/>
<img src="https://img.shields.io/github/checks-status/dropbox/ttvc/main"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've got this badge listed twice. Were you trying to include something else, or should we just remove one?

@ajhyndman
Copy link
Member

It's cool to see what's possible!

@Jonathan1600 Jonathan1600 merged commit df13354 into main Jun 7, 2022
@Jonathan1600 Jonathan1600 deleted the more-badges branch June 7, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants