Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPA support! #18

Merged
merged 9 commits into from
Apr 14, 2022
Merged

SPA support! #18

merged 9 commits into from
Apr 14, 2022

Conversation

ajhyndman
Copy link
Member

This PR adds a few more SPA test cases and fixes them.

Jonathan1600
Jonathan1600 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@Jonathan1600 Jonathan1600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the canceling methods really clean and easy to read!

@ajhyndman ajhyndman merged commit 8124943 into main Apr 14, 2022
@ajhyndman ajhyndman deleted the spa-support branch April 14, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonathan1600 Jonathan1600 Jonathan1600 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajhyndman @Jonathan1600