Test against mobile browsers (only on CI) (#49)

* Test against mobile browsers in CI * Skip scroll event test in mobile devices * typo fix Co-authored-by: Andrew Hyndman <ahyndman@dropbox.com>
dropbox · Jun 8, 2022 · bb62f6a · bb62f6a
1 parent 62df344
commit bb62f6a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -64,20 +64,6 @@ const config: PlaywrightTestConfig = {
       },
     },
 
-    /* Test against mobile viewports. */
-    // {
-    //   name: 'Mobile Chrome',
-    //   use: {
-    //     ...devices['Pixel 5'],
-    //   },
-    // },
-    // {
-    //   name: 'Mobile Safari',
-    //   use: {
-    //     ...devices['iPhone 12'],
-    //   },
-    // },
-
     /* Test against branded browsers. */
     // {
     //   name: 'Microsoft Edge',
@@ -103,4 +89,22 @@ const config: PlaywrightTestConfig = {
   },
 };
 
+if (process.env.CI) {
+  config.projects?.push(
+    /* Test against mobile viewports (CI only). */
+    {
+      name: 'Mobile Chrome',
+      use: {
+        ...devices['Pixel 5'],
+      },
+    },
+    {
+      name: 'Mobile Safari',
+      use: {
+        ...devices['iPhone 12'],
+      },
+    }
+  );
+}
+
 export default config;
diff --git a/test/e2e/interaction3/index.spec.ts b/test/e2e/interaction3/index.spec.ts
@@ -6,7 +6,9 @@ import {getEntries, entryCountIs} from '../../util/entries';
 const PAGELOAD_DELAY = 500;
 
 test.describe('TTVC', () => {
-  test('an user scrolls', async ({page}) => {
+  test('a user scrolls', async ({page, isMobile}) => {
+    test.skip(Boolean(isMobile), 'wheel events are not defined for mobile devices');
+
     await page.goto(`/test/interaction3?delay=${PAGELOAD_DELAY}`, {});
 
     await page.mouse.wheel(0, 2000);