Skip to content

Commit

Permalink
Report discarded meadurements and cancellation in debug mode (#71)
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew Hyndman <ahyndman@dropbox.com>
  • Loading branch information
ajhyndman and Andrew Hyndman authored Apr 11, 2023
1 parent b32a120 commit 5f0c5e0
Showing 1 changed file with 19 additions and 3 deletions.
22 changes: 19 additions & 3 deletions src/visuallyCompleteCalculator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,20 @@ class VisuallyCompleteCalculator {

/** abort the current TTVC measurement */
cancel() {
Logger.info(
'VisuallyCompleteCalculator.cancel()',
'::',
'index =',
this.activeMeasurementIndex
);
this.activeMeasurementIndex = undefined;
}

/** begin measuring a new navigation */
async start(start = 0) {
const navigationIndex = (this.navigationCount += 1);
this.activeMeasurementIndex = navigationIndex;
Logger.info('VisuallyCompleteCalculator.start()');
Logger.info('VisuallyCompleteCalculator.start()', '::', 'index =', navigationIndex);

// setup
const cancel = () => {
Expand Down Expand Up @@ -128,6 +134,13 @@ class VisuallyCompleteCalculator {
: this.lastMutation,
},
});
} else {
Logger.debug(
'VisuallyCompleteCalculator: Measurement discarded',
'::',
'index =',
navigationIndex
);
}

// cleanup
Expand Down Expand Up @@ -160,9 +173,12 @@ class VisuallyCompleteCalculator {
'lastImageLoadTimestamp =',
this.lastImageLoadTimestamp,
'lastMutationTimestamp =',
this.lastMutation?.timestamp ?? 0
this.lastMutation?.timestamp ?? 0,
'::',
'index =',
this.activeMeasurementIndex
);
Logger.info('TTVC:', measurement);
Logger.info('TTVC:', measurement, '::', 'index =', this.activeMeasurementIndex);
this.subscribers.forEach((subscriber) => subscriber(measurement));
}

Expand Down

0 comments on commit 5f0c5e0

Please sign in to comment.