-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook dependency guard task automatically into check task #30
Comments
Currently, I'm doing: tasks.named("check").configure {
it.dependsOn(tasks.named("dependencyGuard"))
} |
I'm not opposed to it, but am not sure what other libraries do this? Do you know of any plugins that add to the check task? If it is a common thing, I can run it by a few others and we could consider. @autonomousapps any thoughts on this idea? |
Found this which suggests we should add it to check. |
I agree it's fairly common. As a counter-example, my plugin doesn't do this because the analysis it does is far too expensive; and it's also easy for consumers to hook that up if they want. I can't think of any reasons for you not to do it. |
AGP / Java Plugins hook their Since dependency guard is fast, I'd add it to the |
Sounds great. I'll add this to the next version milestone 0.3.0 so it gets in. Should be a trivial code change 👍 Great suggestion! |
This is now part of |
What's your opinion on this? So far this isn't done yet:
./gradlew -m check | grep "dependencyGuard"
returns nothingThe text was updated successfully, but these errors were encountered: