Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook dependency guard task automatically into check task #30

Closed
vanniktech opened this issue May 19, 2022 · 7 comments
Closed

Hook dependency guard task automatically into check task #30

vanniktech opened this issue May 19, 2022 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@vanniktech
Copy link

What's your opinion on this? So far this isn't done yet:

./gradlew -m check | grep "dependencyGuard" returns nothing

@vanniktech
Copy link
Author

Currently, I'm doing:

tasks.named("check").configure {
  it.dependsOn(tasks.named("dependencyGuard"))
}

@handstandsam
Copy link
Collaborator

I'm not opposed to it, but am not sure what other libraries do this? Do you know of any plugins that add to the check task? If it is a common thing, I can run it by a few others and we could consider.

@autonomousapps any thoughts on this idea?

@handstandsam
Copy link
Collaborator

Found this which suggests we should add it to check.

https://tomgregory.com/gradle-check-task-essentials/

@autonomousapps
Copy link
Contributor

I agree it's fairly common. As a counter-example, my plugin doesn't do this because the analysis it does is far too expensive; and it's also easy for consumers to hook that up if they want. I can't think of any reasons for you not to do it.

@vanniktech
Copy link
Author

AGP / Java Plugins hook their test tasks automatically into check. Android also does it for the integration tests.

Since dependency guard is fast, I'd add it to the check task.

@handstandsam
Copy link
Collaborator

Sounds great. I'll add this to the next version milestone 0.3.0 so it gets in. Should be a trivial code change 👍

Great suggestion!

@handstandsam handstandsam added this to the 0.3.0 milestone May 23, 2022
@handstandsam handstandsam added the enhancement New feature or request label May 23, 2022
@handstandsam
Copy link
Collaborator

This is now part of 0.3.0 which I just kicked off the publishing job for with the @vanniktech plugin 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants