KMM[Domain] Add a repository to fetch feed information #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibettheophilus
force-pushed
the
fetch-feed-info
branch
from
dd54ad3
to
7d0d4d4
Compare
Added the Feed repository interface and its implementation. Added copyright to the files.
kibettheophilus
commented
Jun 19, 2024
| } | ||
|
|
||
| override suspend fun syncFeed() { | ||
| val feeds = mutableListOf<FeedDomainModel>() |
There was a problem hiding this comment.
@chepsi this should be used for doing the background sync but since there is no implementation, I just added this instead of leaving it empty.
kibettheophilus
requested review from
chepsi,
wangerekaharun,
michaelbukachi,
jumaallan,
misshannah and
MamboBryan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Please make sure to read the Contribution Guidelines
and check that you understand and have followed it as best as possible Explain what your feature
does in a short paragraph. please check the below boxes
./codeAnalysis.shon linux/unix orcodeAnalysys.baton windows to make sure all lint/formatting checks have been done.Closes/Fixes Issues
Declare any issues by typing
fixes #1orcloses #1for example so that the automation can kickin when this is merged
Other testing QA Notes
What have you tested specifically and what possible impacts/areas there are that may need retesting
by others.
Please add a screenshot (if necessary)