Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old Python 3.6 code paths #57

Merged
merged 10 commits into from
Jun 3, 2022
Merged

Clean up old Python 3.6 code paths #57

merged 10 commits into from
Jun 3, 2022

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Jun 3, 2022

There are a few code paths for handling Python 3.6 typing library quirks. These should no longer be necessary.

Also minor documentation changes:

@@ -42,7 +42,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest] # [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.7, 3.8, 3.9, "3.10"]
python-version: ["3.7.3", 3.7, 3.8, 3.9, "3.10"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious about the reason for explicitly including 3.7.3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because some of the imports are for cases < 3.7.4. Those stopped being covered when we removed 3.6 in #56.

https://app.codecov.io/gh/drivendataorg/erdantic/compare/56

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #57 (dabc381) into main (91beca6) will increase coverage by 2.4%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main     #57     +/-   ##
=======================================
+ Coverage   95.5%   97.9%   +2.4%     
=======================================
  Files         13      13             
  Lines        517     492     -25     
=======================================
- Hits         494     482     -12     
+ Misses        23      10     -13     
Impacted Files Coverage Δ
erdantic/exceptions.py 97.2% <100.0%> (+6.5%) ⬆️
erdantic/typing.py 100.0% <100.0%> (+11.7%) ⬆️

@jayqi jayqi merged commit 4d8e326 into main Jun 3, 2022
@jayqi jayqi deleted the python36-code-paths branch June 3, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants