-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up old Python 3.6 code paths #57
Conversation
.github/workflows/tests.yml
Outdated
@@ -42,7 +42,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, macos-latest] # [ubuntu-latest, macos-latest, windows-latest] | |||
python-version: [3.7, 3.8, 3.9, "3.10"] | |||
python-version: ["3.7.3", 3.7, 3.8, 3.9, "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious about the reason for explicitly including 3.7.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because some of the imports are for cases < 3.7.4. Those stopped being covered when we removed 3.6 in #56.
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
+ Coverage 95.5% 97.9% +2.4%
=======================================
Files 13 13
Lines 517 492 -25
=======================================
- Hits 494 482 -12
+ Misses 23 10 -13
|
There are a few code paths for handling Python 3.6 typing library quirks. These should no longer be necessary.
Also minor documentation changes:
python-legacy
. The newpython
handler doesn't yet properly handle properties. Properties are rendered with parens mkdocstrings/python#9