nydusify: fix unit test fail #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
requested review from
jiangliu,
ccx1024cc and
changweige
and removed request for
a team
utils_test.go:248:
Error Trace: /root/nydus/contrib/nydusify/pkg/utils/utils_test.go:248
Error: Should be true
Test: TestRetryWithHTTP
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
fix-ci-contrib-ut
branch
from
bfd9342
to
fab8a6f
Compare
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
fix-ci-contrib-ut
branch
from
5970b3a
to
8d2f0e9
Compare
Desiki-high
changed the title
Desiki-high
changed the title
Desiki-high
force-pushed
the
fix-ci-contrib-ut
branch
4 times, most recently
from
0d3e36b
to
bbf7495
Compare
`sudo` in action will change go env, remove sudo. In runner user, we can create file in unpacktargz-test inseted of temp/unpacktargz-test, so don't use os.CreateTemp in archive_test.go. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
fix-ci-contrib-ut
branch
from
bbf7495
to
bd02185
Compare
Desiki-high
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
+ Coverage 60.90% 61.29% +0.39%
==========================================
Files 141 145 +4
Lines 46265 46617 +352
Branches 44153 44153
==========================================
+ Hits 28177 28575 +398
+ Misses 16648 16591 -57
- Partials 1440 1451 +11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Details
sudoincontrib-unit-test-coverage.sudowill change go env, andgo vetwill break.utils_test.gowith nydusify: refactor withhttp.ErrSchemeMismatchandsyscall.ECONNREFUSED#1528.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.