Dev #3
Merged
Dev #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindReadline.cmake has been refactored for better handling of the Readline library on macOS. This update manually finds the Readline library on macOS, which is necessary because the pkg-config file might not always be available on this platform. This change makes our code more robust for macOS users. Additionally, the process of printing information about the Readline library has been encapsulated in the `print_readline_info` function for better code modularity and readability.
Moved the detailed listing of source files from src/CMakeLists.txt to main CMakeLists.txt using file(GLOB_RECURSE). This change aims to simplify the source management as it will automatically include any newly added .cpp or .hpp file, preventing the need to manually add each newly created source file into the src/CMakeLists.txt.
Installation script for BLAKE3 has been refactored for better error handling and OS detection. Functions were introduced to handle common tasks such as error exit, detecting OS, checking root access, getting the number of processors, cloning the repository, and building & installing BLAKE3. This enhancement increases the robustness of the script and eases its usage on different Unix-like systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.