-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 1154 Add LOGOUT_REDIRECT_URL setting #1749
Conversation
… into 1154-use-LOGOUT_REDIRECT_URL
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 56 56
Lines 8136 8136
=======================================
Hits 6255 6255
Misses 1881 1881
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Commenting so the stalebot doesn't mark this as stale. This PR is in a mergable state, it just needs a review. |
Thank you! |
Description
This pull request addresses #1154, by redirecting to
LOGOUT_REDIRECT_URL
in the/logout
view ifLOGOUT_REDIRECT_URL
is set in the config, falling back toself.appbuilder.get_url_for_index
.It also adds
LOGOUT_REDIRECT_URL
to the Configuration keys table indocs/config.rst
, and adds a unit test.This PR is the exact same changes as #1160, but reopened since that one didn't seem to garner any feedback or interest once it was closed by the stale bot. This PR will cleanly merge, and will likely also solve apache/airflow#17279, so there is already people waiting on this fix to be merged.
ADDITIONAL INFORMATION