Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added sr-only class to icon only links #1727

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

ThomasStivers
Copy link
Contributor

The sr-only class tells bootstrap to present information only to users of screen readers so they are able to identify links represented only by icons.

fixes #1723

Description

ADDITIONAL INFORMATION

  • Has associated issue: Screen Reader Accessibility #1723
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

…k_show macros.

The sr-only class tells bootstrap to present information only to users of screen readers so they are able to identify links represented only by icons.
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1727 (f06d98c) into master (071e66b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
+ Coverage   76.77%   76.80%   +0.03%     
==========================================
  Files          56       56              
  Lines        8115     8115              
==========================================
+ Hits         6230     6233       +3     
+ Misses       1885     1882       -3     
Flag Coverage Δ
python 76.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/sqla/manager.py 70.91% <0.00%> (+0.27%) ⬆️
flask_appbuilder/models/sqla/interface.py 78.84% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071e66b...f06d98c. Read the comment docs.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, left a couple of comments

flask_appbuilder/templates/appbuilder/general/lib.html Outdated Show resolved Hide resolved
flask_appbuilder/templates/appbuilder/general/lib.html Outdated Show resolved Hide resolved
flask_appbuilder/templates/appbuilder/general/lib.html Outdated Show resolved Hide resolved
@dpgaspar dpgaspar merged commit 1efbbcc into dpgaspar:master Nov 18, 2021
@dpgaspar
Copy link
Owner

@ThomasStivers will be out on the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen Reader Accessibility
2 participants