Fix false positive for global navigation check in typescript #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript code would always have the LIMIT_NAVIGATION_GLOBAL_CHECK fail. This was happening because the atomic LIMIT_NAVIGATION_JS_CHECK was looking for an AST node of type Literal, instead of using AstHelper.StringLiteral. As a result, the check worked properly for javascript code but not typescript.
This PR: