Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nodeintegrationinsubframes #52

Closed
ikkisoft opened this issue Jun 7, 2019 · 2 comments
Closed

Support for nodeintegrationinsubframes #52

ikkisoft opened this issue Jun 7, 2019 · 2 comments

Comments

@ikkisoft
Copy link
Contributor

ikkisoft commented Jun 7, 2019

Is your feature request related to a problem? Please describe.
https://electronjs.org/docs/all#nodeintegrationinsubframes is not currently supported (even if it's experimental)

@phosphore
Copy link
Contributor

I would add it in the NodeIntegrationJSCheck just like we did with nodeIntegrationInWorker in 7f0ba54:

this.findNode(astHelper, target, 'nodeIntegrationInWorker', value => value !== true, loc);

Btw should we consider splitting the check in case more nodeIntegration flags will be added in the future?

phosphore added a commit that referenced this issue Jun 11, 2019
@phosphore
Copy link
Contributor

HTML check is still to be added for cases like:
<webview src="http://www.google.com/" nodeintegrationinsubframes></webview>

@phosphore phosphore reopened this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants