[wasm-browser][tests] Fix issue with some tests exiting with no output #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is that these tests run very quickly, writing to the console.log very fast, and selenium seems to not return the logs during that time. So, when the tests are done, which is indicated by an html element being set, we stop listening for more log messages. And exit with the test exit code, but no output messages from the test run. Eg: `System.Data.Common`
|
This might fix, or help with debugging the |
|
/cc @premun |
|
@radical would you happen to have example builds where I could see the problem? |
premun
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that these tests run very quickly, writing to the
console.log very fast, and selenium seems to not return the logs during
that time. So, when the tests are done, which is indicated by an html
element being set, we stop listening for more log messages.
And exit with the test exit code, but no output messages from the test
run.
Eg:
System.Data.Common