Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public key token. #3794

Conversation

StephenBonikowsky
Copy link
Member

  • Arcade infrastructure set the default value to 'MicrosoftShared' which resulted in token 31BF3856AD364E35
  • It should have been set to 'Microsoft' for token b03f5f7f11d50a3a

fixes #3787

* Arcade infrastructure set the default value to 'MicrosoftShared' which resulted in token 31BF3856AD364E35
* It should have been set to 'Microsoft' for token b03f5f7f11d50a3a
@StephenBonikowsky
Copy link
Member Author

Getting some really strange check failures, going to close and re-open.

@StephenBonikowsky
Copy link
Member Author

Ignoring all the "dotnet-wcf-ci-clone" checks, everything looks good now.

@StephenBonikowsky
Copy link
Member Author

I'm going to merge so that I can build packages and have the vendors validate before we provide them for release.

@StephenBonikowsky StephenBonikowsky merged commit b7bc8bb into dotnet:master Aug 8, 2019
@botinko
Copy link

botinko commented Aug 15, 2019

@StephenBonikowsky After this change I found strange behavior, when my project is referenced to 4.6.0-preview8.final version of system.servicemodel.primitives. I got error: Could not load file or assembly 'System.ServiceModel.Primitives, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. . Output folder contains system.servicemodel.primitives.dll with PublicKeyToken=b03f5f7f11d50a3a
This files
system.servicemodel.primitives\4.6.0-preview8.final\lib\net461\System.ServiceModel.Primitives.dll
system.servicemodel.primitives\4.6.0-preview8.final\ref\net461\System.ServiceModel.Primitives.dll
now have different publickKeyToken.
I'm not sure, but It seems that this leads to the fact that the msbuild puts a ref to one version of the library(31bf3856ad364e35), and copies another(b03f5f7f11d50a3a).

@StephenBonikowsky
Copy link
Member Author

@botinko thank you for reporting this, I will look into it and see what is going on.

@StephenBonikowsky StephenBonikowsky deleted the stebon/master/FixPublicKeyToken branch September 9, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.ServiceModel.Http 4.6.0-preview6.final incompatible with 4.5.3?
3 participants