Add support for KDE Neon (and other Linux distros with ID_LIKE) #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| VERSION="1.0 (rogers)" | ||
| ID=MakeBelieve`; | ||
|
|
||
| return LinuxDistribution.FromReleaseInfo(input, '\n'); |
| @@ -69,14 +71,17 @@ export class LinuxDistribution { | |||
| else if (key === 'VERSION_ID') { | |||
| version = value; | |||
| } | |||
| else if (key === 'ID_LIKE') { | |||
| idLike = value.split(" "); | |||
| } | |||
|
|
|||
| if (name !== unknown && version !== unknown) { | |||
There was a problem hiding this comment.
Is the intended design that we will ignore ID_LIKE if ID and VERSION_ID are set?
There was a problem hiding this comment.
We ignore ID_LIKE if ID is something we understand. If we don't understand ID, we will iterate through the ID_LIKE values to see if we understand any of them.
There was a problem hiding this comment.
Is that what it does though? It looks like it will bail if ID_LIKE hasn't been encountered and we find ID and VERSION_ID values -- even if we don't understand them.
This checkin adds support for checking the ID_LIKE field in the os-release file to try and find a compatible base OS. This support is imperfect since ID_LIKE doesn't provide a version number for the downstream OS(s). But this at least works for KDE Neon.
gregg-miskelly
force-pushed
the
KDENeon
branch
from
a54683f
to
a2b4ed8
Compare
|
Did you force push? |
DustinCampbell
approved these changes
Nov 9, 2016
|
|
||
| if (name !== unknown && version !== unknown) { | ||
| if (name !== unknown && version !== unknown && idLike !== null) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checkin adds support for checking the ID_LIKE field in the os-release file to try and find a compatible base OS. This support is imperfect since ID_LIKE doesn't provide a version number for the downstream OS(s). But this at least works for KDE Neon.
Associated issue: #879