Ensure the fix all resolve request reads an existing field #7536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
fix_all_fix
branch
from
8ba754e
to
7b86e76
Compare
arkalyanms
approved these changes
Sep 9, 2024
dibarbet
added a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Sep 9, 2024
Ensure the fix all resolve request reads an existing field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title property never existed on the data object we get from the server. A server side change made it required for all code action requests (per LSP spec), so started throwing when we passed null.
This changes the client side to pass a value that is always provided in the data - https://github.com/dotnet/roslyn/blob/bd5c00e5e09de8564093f42d87fe49d4971f2e84/src/LanguageServer/Protocol/Handler/CodeActions/CodeActionResolveData.cs#L26
Resolves #7535