Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project.json support #7244

Merged
merged 1 commit into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions omnisharptest/omnisharpUnitTests/assets.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ describe('Asset generation: csproj', () => {
isNotNull(tasksJson.tasks[0].args);
const buildPath = tasksJson.tasks[0].args[1];

// ${workspaceFolder}/project.json
const segments = buildPath.split(path.posix.sep);
expect(segments).toStrictEqual(['${workspaceFolder}', 'testApp.csproj']);
});
Expand Down Expand Up @@ -123,7 +122,6 @@ describe('Asset generation: csproj', () => {
isNotNull(tasksJson.tasks[0].args);
const buildPath = tasksJson.tasks[0].args[1];

// ${workspaceFolder}/nested/project.json
const segments = buildPath.split(path.posix.sep);
expect(segments).toStrictEqual(['${workspaceFolder}', 'nested', 'testApp.csproj']);
});
Expand Down
5 changes: 0 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,6 @@
"onLanguage:csharp",
"onCommand:o.showOutput",
"onCommand:omnisharp.registerLanguageMiddleware",
"workspaceContains:project.json",
"workspaceContains:**/*.{csproj,csx,cake}"
],
"contributes": {
Expand Down Expand Up @@ -1864,10 +1863,6 @@
],
"url": "https://json.schemastore.org/appsettings"
},
{
"fileMatch": "project.json",
"url": "http://json.schemastore.org/project"
},
{
"fileMatch": "omnisharp.json",
"url": "http://json.schemastore.org/omnisharp"
Expand Down
5 changes: 1 addition & 4 deletions src/features/dotnetTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export default class TestManager extends AbstractProvider {
if (projectInfo.MsBuildProject) {
targetFrameworkVersion = projectInfo.MsBuildProject.TargetFramework;
} else {
throw new Error('Expected project.json or .csproj project.');
throw new Error('Expected .csproj project.');
}

return targetFrameworkVersion;
Expand Down Expand Up @@ -480,9 +480,6 @@ export default class TestManager extends AbstractProvider {
}

public async debugDotnetTest(testMethod: string, fileName: string, testFrameworkName: string, noBuild = false) {
// We support to styles of 'dotnet test' for debugging: The legacy 'project.json' testing, and the newer csproj support
// using VS Test. These require a different level of communication.

this._eventStream.post(new DotNetTestDebugStart(testMethod));

const { debugEventListener, targetFrameworkVersion } = await this._recordDebugAndGetDebugValues(
Expand Down
213 changes: 0 additions & 213 deletions src/features/json/jsonContributions.ts

This file was deleted.

10 changes: 0 additions & 10 deletions src/features/json/nuGetFlatContainerPackageResponse.ts

This file was deleted.

14 changes: 0 additions & 14 deletions src/features/json/nuGetIndexResponse.ts

This file was deleted.

10 changes: 0 additions & 10 deletions src/features/json/nuGetSearchAutocompleteServiceResponse.ts

This file was deleted.

16 changes: 0 additions & 16 deletions src/features/json/nuGetSearchQueryServiceResponse.ts

This file was deleted.

Loading
Loading