List solution filter files (.slnf) in the 'Open Solution' command. #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoeRobich
commented
Apr 30, 2024
JoeRobich
commented
- Fixes sorting of solutions in the workspace root path.
- Fixes sorting of solutions in the workspace root path.
dibarbet
reviewed
Apr 30, 2024
| @@ -178,7 +178,7 @@ async function openSolution(languageServer: RoslynLanguageServer): Promise<vscod | |||
| return undefined; | |||
| } | |||
|
|
|||
| const solutionFiles = await vscode.workspace.findFiles('**/*.sln'); | |||
| const solutionFiles = await vscode.workspace.findFiles('**/*.{sln,slnf}'); | |||
There was a problem hiding this comment.
Does the server side actually work for this? Specifically I don't know if the msbuild API we're calling parses the sln file
https://github.com/dotnet/roslyn/blob/main/src/Workspaces/Core/MSBuild.BuildHost/BuildHost.cs#L159
There was a problem hiding this comment.
This does work. Verified with local testing and reviewing the MSBuild API itself. Looks like we could simplify some MSBuildWorkspace handling of Solution Filters by using this same api.
dibarbet
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.