Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighter shows XML comment tags incorrectly #706

Closed
FiniteReality opened this issue Aug 24, 2016 · 2 comments
Closed

Syntax highlighter shows XML comment tags incorrectly #706

FiniteReality opened this issue Aug 24, 2016 · 2 comments

Comments

@FiniteReality
Copy link

FiniteReality commented Aug 24, 2016

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.0-preview2-003121)

Product Information:
 Version:            1.0.0-preview2-003121
 Commit SHA-1 hash:  1e9d529bc5

Runtime Environment:
 OS Name:     debian
 OS Version:  8
 OS Platform: Linux
 RID:         debian.8-x64

VS Code version:

Version 1.4.0
Commit 6276dcb0ae497766056b4c09ea75be1d76a8b679
Date 2016-08-04T16:49:32.489Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

C# Extension version: 1.3.0

Steps to reproduce

Make an Enum (or any type for that matter) and place XML comments on the type, and some of the members.

For example:

/// <summary> This is a test Enum </summary>
public enum TestEnum
{
    /// <summary> Test Value One </summary>
    TestValueOne = 0,
    /// <summary> Test Value Two </summary>
    TestValueTwo = 1
}

Expected behavior

The highlighter should highlight the <summary> tags using the same colour. (e.g. like GitHub's syntax highlighter does correctly)

Actual behavior

They aren't:

Upon removing part of the closing tag on the topmost XML comment, the inner comments appear to show correctly, though part of the type definition is highlighted incorrectly:

@DustinCampbell
Copy link
Member

This should look much better in the next release:

image

DustinCampbell added a commit to DustinCampbell/omnisharp-vscode that referenced this issue Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@DustinCampbell @FiniteReality and others