Add conditions for implicit framework references for .NET 3.5 and below #561
Conversation
| @@ -77,18 +77,18 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup Condition=" '$(DisableImplicitFrameworkReferences)' != 'true' and '$(TargetFrameworkIdentifier)' == '.NETFramework'"> | |||
| <!-- When doing greater than/less than comparisons between strings, MSBuild will try to parse the strings as Version objects and compare them as | |||
There was a problem hiding this comment.
Separate item groups with conditions would be clearer.
There was a problem hiding this comment.
There's already a condition on the item group: Condition=" '$(DisableImplicitFrameworkReferences)' != 'true' and '$(TargetFrameworkIdentifier)' == '.NETFramework'"
So splitting into separate item groups based on the target framework version would mean duplicating that condition and adding an additional clause for the version. I don't think that would end up being clearer.
There was a problem hiding this comment.
Then manually group by similar conditions?
…T they were added in
|
Shouldn't a similar set of changes be included for the Xamarin platforms? They need/should have implicit references added as well to match, plus their platform lib |
Merge release/3.0.1xx to master
Fixes #532
There aren't any tests for this, as we run all our tests using the .NET CLI version of MSBuild, which doesn't support targeting .NET 3.5 and lower (as there are no reference assemblies for these frameworks).